EBC backward numeric correctness tests #2162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding numeric correctness check for backward. Verifying that TBE inplace weights updates are numerically correct with eager updates, float inputs with requires_grad grads are numerically correct with eager grads. I saw some data dependent errors on subsequent inputs for VB path, disabling checks for extra inputs for now (`n_extra_numerics_checks_inputs = 0` and TODO in the source). Differential Revision: D58948988
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58948988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding numeric correctness check for backward.
Verifying that TBE inplace weights updates are numerically correct with eager updates, float inputs with requires_grad grads are numerically correct with eager grads.
I saw some data dependent errors on subsequent inputs for VB path, disabling checks for extra inputs for now (
n_extra_numerics_checks_inputs = 0and TODO in the source).Differential Revision: D58948988