Fix bug on VBE+CPU #2256
Closed
Fix bug on VBE+CPU #2256
+122
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60430765 |
|
This pull request was exported from Phabricator. Differential Revision: D60430765 |
dstaay-fb
force-pushed
the
export-D60430765
branch
from
0ce84f9 to
959e027
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60430765 |
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#2256 Internal users reported a bug working with VBE + CPU. Identified regression was introduced by stray edit in D55695198. Simple 1-line fix, but added unit test to cover this edge case for both CPU + GPU setups. Reviewed By: TroyGarden Differential Revision: D60430765
dstaay-fb
force-pushed
the
export-D60430765
branch
from
959e027 to
18bc6db
Compare
Summary: Pull Request resolved: pytorch#2256 Internal users reported a bug working with VBE + CPU. Identified regression was introduced by stray edit in D55695198. Simple 1-line fix, but added unit test to cover this edge case for both CPU + GPU setups. Reviewed By: TroyGarden Differential Revision: D60430765
|
This pull request was exported from Phabricator. Differential Revision: D60430765 |
dstaay-fb
force-pushed
the
export-D60430765
branch
from
18bc6db to
629fd71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Internal users reported a bug working with VBE + CPU. Identified regression was introduced by stray edit in D55695198.
Simple 1-line fix, but added unit test to cover this edge case for both CPU + GPU setups.
Differential Revision: D60430765