Harmonize functional transforms arguments

[vfdev-5]

🚀 Feature

Currently, we can observe a certain freedom in argument names and their meaning:

1. Methods F.resize, F.resized_crop, F.perspective

vision/torchvision/transforms/functional.py

Line 313 in ab73b44

def resize(img: Tensor, size: List[int], interpolation: int = Image.BILINEAR) -> Tensor:

vision/torchvision/transforms/functional.py

Lines 443 to 445 in ab73b44

	def resized_crop(
	img: Tensor, top: int, left: int, height: int, width: int, size: List[int], interpolation: int = Image.BILINEAR
	) -> Tensor:

vision/torchvision/transforms/functional.py

Line 512 in ab73b44

def perspective(img, startpoints, endpoints, interpolation=Image.BICUBIC, fill=None):

have

• interpolation argument
• fill argument

2. Methods F.rotate, F.affine

vision/torchvision/transforms/functional.py

Line 761 in ab73b44

def rotate(img, angle, resample=False, expand=False, center=None, fill=None):

vision/torchvision/transforms/functional.py

Lines 843 to 846 in ab73b44

	def affine(
	img: Tensor, angle: float, translate: List[int], scale: float, shear: List[float],
	resample: int = 0, fillcolor: Optional[int] = None
	) -> Tensor:

have

• resample argument for interpolation (with a wrong default value as bool instead of int)
• fill or fillcolor arguments for filling outside part of image

3. Argument angle is interpreted differently between F.rotate, F.affine.

• Affine: angle (float or int): rotation angle in degrees between -180 and 180, clockwise direction.
• Rotate: angle (float or int): In degrees degrees counter clockwise order.

Idea is to harmonize the API:

• choose a single name for interpolation and resample
• choose a single name for fill and fillcolor
• BC breaking change for angle ?

Maybe, there are other arguments to add to this list.

[vfdev-5]

Similar things with Transforms module and classes:

• RandomRotation: fill/resample
• RandomAffine: fillcolor/resample
• RandomPerspective: fill/interpolation
• RandomResizedCrop: interpolation
• Pad: fill
• RandomCrop: fill
• Resize: interpolation

1. fill is mainly used: 4 times in transforms and 3 times in functional vs fillcolor is used 2 times in transforms and functional (RandomAffine and F.affine) => we can decide to replace fillcolor by fill and set a warning about argument deprecation.

2. interpolation is used 6 times in transforms/functional vs resample is used 4 times in transforms/functional => we can similarly decide to replace resample by interpolation and set a warning about argument deprecation.

[vfdev-5]

Close this issue as fixed by #2952 and #2904