-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Use Union in Torchscript #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's great news, on top of #4323, a top priority regarding this would be to fix the annotations that are currently incorrect because we were lacking Union support in the past |
I think it is supported but the docs haven't updated the change? https://pytorch.org/docs/master/jit_language_reference.html#supported-type |
@oke-aditya pytorch/pytorch#68435 should fix that 👍 |
So nice of you @frgfm Francois. Merci beaucoup!! |
🚀 The feature
Use Union in Torchscript.
pytorch/pytorch#64234
Motivation, pitch
Now that Union typing support is merged. We can rewrite the workarounds which don't support Union.
E.g we can now proceed with #4323
There maybe more places so we can track them in this Issue too.
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: