Skip to content

Port transforms.RandomVerticalFlip to prototype.transforms #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #5520
pmeier opened this issue Mar 3, 2022 · 3 comments · Fixed by #5633
Closed
Tracked by #5520

Port transforms.RandomVerticalFlip to prototype.transforms #5524

pmeier opened this issue Mar 3, 2022 · 3 comments · Fixed by #5633
Assignees
@federicopozzi33
Labels
module: transforms prototype

Comments

@pmeier
Copy link
Collaborator

pmeier commented Mar 3, 2022 •
edited by pytorch-bot bot
Loading

cc @vfdev-5 @datumbox @bjuncek
@pmeier pmeier mentioned this issue Mar 3, 2022
Closed
28 tasks
@federicopozzi33
Copy link
Contributor

Hi @pmeier,

I'd like to work on this issue.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 15, 2022

Go ahead!

Just as a heads-up: in the light of #5520 (comment) we want to put a hold on community contributions for now. We agreed we can special case this port, since you already did #5523 and this is very similar. If you are up for it, we will happily ping you when the hold is lifted for other transforms.

@federicopozzi33
Copy link
Contributor

Go ahead!

Just as a heads-up: in the light of #5520 (comment) we want to put a hold on community contributions for now. We agreed we can special case this port, since you already did #5523 and this is very similar. If you are up for it, we will happily ping you when the hold is lifted for other transforms.

Ok.

Yeah, I'd like to work on the other transforms too!

In the meanwhile, I'll work on this one.

federicopozzi33 pushed a commit to federicopozzi33/vision that referenced this issue Mar 16, 2022
refactor: port RandomVerticalFlip to prototype API (pytorch#5524)
d6ba543
@federicopozzi33 federicopozzi33 mentioned this issue Mar 16, 2022
Merged
datumbox pushed a commit that referenced this issue Mar 17, 2022
@federicopozzi33
refactor: port RandomVerticalFlip to prototype API (#5524) (#5633)
585b3b1 
Co-authored-by: Federico Pozzi <[email protected]>
facebook-github-bot pushed a commit that referenced this issue Apr 5, 2022
@jdsgomes @facebook-github-bot
[fbsync] refactor: port RandomVerticalFlip to prototype API (#5524) (#…
0fdc835 
…5633)

Summary:

(Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216779

fbshipit-source-id: 493f6eac276a1ec2f5ed869493db4eef548b3369

Co-authored-by: Federico Pozzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@federicopozzi33 federicopozzi33

Labels
module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: port RandomVerticalFlip to prototype API (#5524) federicopozzi33/vision
2 participants
@pmeier @federicopozzi33