Skip to content

Not all prototype kernels support arbitrary batch sizes #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmeier opened this issue Sep 30, 2022 · 2 comments · Fixed by #6726
Closed

Not all prototype kernels support arbitrary batch sizes #6670

pmeier opened this issue Sep 30, 2022 · 2 comments · Fixed by #6726

Comments

@pmeier
Copy link
Collaborator

pmeier commented Sep 30, 2022

There are currently five image kernels that don't support arbitrary batch sizes:

cc @vfdev-5 @datumbox @bjuncek

@pmeier
Copy link
Collaborator Author

pmeier commented Oct 6, 2022

The situation is a little more nuanced:

  • All kernel from above except adjust_sharpness don't support 5d+ inputs or a 4d inputs with a degenerate batch dimension, i.e. (0, C, H, W)

  • adjust_sharpness also doesn't support 5d+ inputs, but does support 4d inputs with a degenerate batch dimension iff the input only has a single channel, i.e. (0, 1, H, W). In addition, if the shortcut

    if img.size(-1) <= 2 or img.size(-2) <= 2:
    return img

    is triggered, arbitrary batch sizes are supported.

@pmeier
Copy link
Collaborator Author

pmeier commented Oct 6, 2022

#6667 adds xfails for these cases.

Edit: The PR ended up fixing equalize and adjust_sharpness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant