Skip to content

Fix EMNSIT download URL #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix EMNSIT download URL #1318

merged 2 commits into from
Sep 9, 2019

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 9, 2019

fixes #1296

@fmassa The link you provided works as drop-in replacement. The website looks official to me, since it comprises citing information and so on. Do you want me to include a comment why this does not link to the official dataset website?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Can you update the comments with the place where you found the new URL from?

@codecov-io
Copy link

Codecov Report

Merging #1318 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1318      +/-   ##
=========================================
+ Coverage   65.58%   65.6%   +0.01%     
=========================================
  Files          74      74              
  Lines        5786    5786              
  Branches      884     884              
=========================================
+ Hits         3795    3796       +1     
+ Misses       1726    1725       -1     
  Partials      265     265
Impacted Files Coverage Δ
torchvision/datasets/mnist.py 51.7% <100%> (ø) ⬆️
torchvision/transforms/transforms.py 80.94% <0%> (-0.59%) ⬇️
torchvision/transforms/functional.py 71.38% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe234fc...16cbe57. Read the comment docs.

@fmassa fmassa merged commit 6ddda3a into pytorch:master Sep 9, 2019
@pmeier pmeier deleted the emnist_fix branch September 12, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMNIST download url changed
3 participants