add _backend argument to __init__() of class VideoClips #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Sep 24, 2019
| @@ -49,9 +67,11 @@ class VideoClips(object): | |||
| on the resampled video | |||
| """ | |||
| def __init__(self, video_paths, clip_length_in_frames=16, frames_between_clips=1, | |||
| frame_rate=None, _precomputed_metadata=None, num_workers=1): | |||
| frame_rate=None, _precomputed_metadata=None, num_workers=1, | |||
| _backend="pyav"): | |||
There was a problem hiding this comment.
Instead of passing a _backend argument, what about just using the get_video_backend to get this? Would this be enough for your use-case?
There was a problem hiding this comment.
I'm sending a commit changing backend to _backend in the self, so no need to do anything here.
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 64.76% 64.41% -0.36%
==========================================
Files 76 76
Lines 5975 6028 +53
Branches 915 929 +14
==========================================
+ Hits 3870 3883 +13
- Misses 1833 1869 +36
- Partials 272 276 +4
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
to facebookresearch/ClassyVision
that referenced
this pull request
Oct 16, 2019
Summary: Pull Request resolved: #62 Current dependency torchvision 0.4.0 was released in August. It missed quite a few PRs that are merged after that, and that are needed for video classification, such as - pytorch/vision#1437 - pytorch/vision#1431 - pytorch/vision#1423 - pytorch/vision#1418 - pytorch/vision#1408 - pytorch/vision#1376 - pytorch/vision#1363 - pytorch/vision#1353 - pytorch/vision#1303 This will fail the CI test when a diff uses changes made in those PRs. Before a new official version of TorchVision is released, we can temporarily use the nightly torchvision to get all the recent PRs, and unblock the PR merging. We plan to use a fixed version of TorchVision later. Reviewed By: vreis Differential Revision: D17944239 fbshipit-source-id: 86ff540e3fc4f08ef767e84ef103525db5158201
fmassa
pushed a commit
that referenced
this pull request
Oct 31, 2019
* add _backend argument to __init__() of class VideoClips * minor fix * minor fix * Make backend private in VideoClips * Fix lint * Fix conflict due to cherry-pick for 0.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
VideoClips, add an argument_backendto switch between pyav and video_reader backend.torchvision/__init__.py, add a global variable to control the video backendtest/test_io.pyandtest/test_datasets_video_utils.pyto retrieve global video backend configUnit test
test/test_io.pytest/test_datasets_video_utils.py