[DONOTMERGE] Port PSROIPool to use the Dispatcher and support Autocast #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
changed the title
datumbox
commented
Oct 28, 2020
torchvision/csrc/PSROIPool.h
Outdated
| ctx->save_for_backward({rois, channel_mapping}); | ||
| ctx->mark_non_differentiable({channel_mapping}); | ||
| return {output, channel_mapping}; | ||
| auto mapping_channel = std::get<1>(result); |
There was a problem hiding this comment.
In case anybody wonders about this change, in this codebase we used both mapping_channel and channel_mapping. Here I picked mapping_channel, but later on #2926 I replace it everywhere with channel_mapping which I think makes more sense.
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
=======================================
Coverage 73.41% 73.41%
=======================================
Files 99 99
Lines 8801 8801
Branches 1389 1389
=======================================
Hits 6461 6461
Misses 1915 1915
Partials 425 425 Continue to review full report at Codecov.
|
datumbox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes moved to #2926