Adds Anchor tests with ground-truth outputs #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2983 +/- ##
=======================================
Coverage 73.39% 73.39%
=======================================
Files 99 99
Lines 8825 8825
Branches 1391 1391
=======================================
Hits 6477 6477
Misses 1929 1929
Partials 419 419 Continue to review full report at Codecov.
|
fmassa
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Thanks!
For a follow-up PR, we could simplify the setup for AnchorGenerator so that it only has say 4 or 9 anchors, and compare it with ground-truth anchor values, such as
[[0, 0, 10, 10],
[10, 10, 20, 20],
...this way we can test that we don't introduce regressions in the computation of the anchors.
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Add AnchorGenerator with ground-truth outputs * Minor fixes
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Add AnchorGenerator with ground-truth outputs * Minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fmassa , As discussed in #2971 , This is the unittest of
AnchorGeneratorwith a groud-truth outputs. There are 3 layers in my configs of the Anchor, and the size of each grid are (4x8), (2x4) and (1x2) respectively, so the estimated number of anchors are 126.