Revert "Update resnet18 test value to fix tests" #2990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
=======================================
Coverage 73.39% 73.39%
=======================================
Files 99 99
Lines 8825 8825
Branches 1391 1391
=======================================
Hits 6477 6477
Misses 1929 1929
Partials 419 419 Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
… to resolve broken tests. (pytorch#2978)" (pytorch#2990) This reverts commit 1f4e3a4.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
… to resolve broken tests. (pytorch#2978)" (pytorch#2990) This reverts commit 1f4e3a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2978
It seems that PyTorch reverted the change that affected our expected values. Here is Travis failing for a new PR:
It seems now the old values are the ones that work, so I propose to revert the change.