Skip to content

Remove hardcoded PNG_FOUND define. #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

datumbox
Copy link
Contributor

PR #2988 had a hardcoded define that was meant only for debugging. This can cause problems to users who compile torchvision from source without the PNG libraries. Here I'm removing it.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups!

Thanks!

@fmassa fmassa merged commit 8c28175 into pytorch:master Nov 18, 2020
@datumbox datumbox deleted the bug/remove_define_flag branch November 18, 2020 13:13
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants