Fix potential overflow in convert_image_dtype #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could have errors such as aten/src/ATen/native/cpu/PowKernel.cpp:41:5: runtime error: 5.7896e+76 is outside the range of representable values of type 'float'
datumbox
reviewed
Dec 3, 2020
|
|
||
| # int to float | ||
| # TODO: replace with dtype.is_floating_point when torchscript supports it | ||
| if torch.tensor(0, dtype=dtype).is_floating_point(): | ||
| image = image.to(dtype) | ||
| return image / input_max | ||
|
|
||
| output_max = _max_value(dtype) |
There was a problem hiding this comment.
It's unclear why moving this it fixes the errors. Shall I assume that the if statement is always activated in the problematic cases and thus you never end up executing this line?
There was a problem hiding this comment.
Yes, the overflow only happens when dtype is floating point, so moving this after the conditional solves this
datumbox
approved these changes
Dec 3, 2020
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
We could have errors such as aten/src/ATen/native/cpu/PowKernel.cpp:41:5: runtime error: 5.7896e+76 is outside the range of representable values of type 'float'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could have errors with
convert_image_dtypesuch asThis fixes it for now, while we can't use
torch.iinfoandtorch.finfoin torchscript