[ONNX] Fix roi_align ONNX export #3355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KsenijaS
changed the title
|
@KsenijaS is the PR ready for review? |
KsenijaS
changed the title
@fmassa Yes, PR is ready for a review. It would be also good that some one from my team review it as well. |
fmassa
requested changes
Mar 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #3355 +/- ##
==========================================
- Coverage 78.86% 78.83% -0.03%
==========================================
Files 105 105
Lines 9752 9753 +1
Branches 1567 1568 +1
==========================================
- Hits 7691 7689 -2
- Misses 1574 1577 +3
Partials 487 487
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 18, 2021
Summary: * add tests * fix bug * remove tests * fix comment * fix comment * add warning * fix syntax error * fix python lint Reviewed By: fmassa Differential Revision: D27127999 fbshipit-source-id: c416f4de87a50a6d5fe3d006341fb84500f2a20d Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow export of roi_align when sampling rate is negative