check inf value for computing iou #3385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check inf value for computing iou
|
@developer0hye Thanks for investigating and confirming the issue. The issue is caused indeed by numeric overflows on types that use very few bytes (such as float16). I have already submitted PR #3383 which does not just assert but addresses the issue on Python and CUDA side. |
|
@datumbox This pr is the subset of your pr, right?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a numeric overflow at #3371, I noticed that the implementations of _box_inter_union() need to check inter and union value.
Actually, when the type of boxes is torch.float16, overflow easily happens.
I expect we can easily check the error with this assert code.