Fix lazy importing for dataset tests #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3481 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 105 105
Lines 9707 9707
Branches 1556 1556
=======================================
Hits 7581 7581
Misses 1637 1637
Partials 489 489 Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Reviewed By: fmassa Differential Revision: D26756263 fbshipit-source-id: 829bd945fdfe560a97f35c53111c5a875958e8e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the order in the
MODULEStuple has an effect on the properties although this shouldn't be the case. This was only caught after #3445 went in and caused tests to fail that passed before:https://app.circleci.com/pipelines/github/pytorch/vision/6611/workflows/beeb6144-8709-442a-8fa2-d30886007613/jobs/439286
With this we now correctly import the top level module as well as all submodules at once.