Skip to content

Add __repr__ for transforms.RandomErasing #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

zeakey
Copy link
Contributor

@zeakey zeakey commented Mar 3, 2021

This PR adds repr for transforms.RandomErasing.

@facebook-github-bot
Copy link

Hi @zeakey!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3491 (f09b0b8) into master (945f3a8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3491      +/-   ##
==========================================
+ Coverage   78.69%   78.71%   +0.01%     
==========================================
  Files         105      105              
  Lines        9704     9711       +7     
  Branches     1555     1555              
==========================================
+ Hits         7637     7644       +7     
  Misses       1576     1576              
  Partials      491      491              
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 84.28% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945f3a8...f09b0b8. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you add a test for this functionality, so that we can merge it?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 89edfaa into pytorch:master Mar 3, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 10, 2021
Reviewed By: NicolasHug, cpuhrsch

Differential Revision: D26945734

fbshipit-source-id: 608c2fa2bd7fc256484c9993c628ca568a4f23d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants