Skip to content

[FBcode->GH] change image type for LSUN tests #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

[FBcode->GH] change image type for LSUN tests #3492

merged 1 commit into from
Mar 3, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 3, 2021

The PIL binary used in FB internal tests does not support webp images. I've only used them, because this type was used in the official code. Since LSUN is otherwise type agnostic, we can simply change the tests.

@pmeier pmeier requested a review from fmassa March 3, 2021 12:05
@fmassa fmassa changed the title change image type for LSUN tests [FBcode->GH] change image type for LSUN tests Mar 3, 2021
@fmassa fmassa merged commit 945f3a8 into pytorch:master Mar 3, 2021
fmassa
fmassa reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmeier pmeier deleted the fix-lsun-fb-internal branch March 3, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa left review comments

Assignees
No one assigned
Labels
cla signed module: datasets module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmeier @fmassa @NicolasHug @facebook-github-bot