[TRANS, IMP] Add new max_size parameter to Resize #3494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
+ Coverage 78.65% 78.76% +0.10%
==========================================
Files 105 105
Lines 9723 9723
Branches 1557 1561 +4
==========================================
+ Hits 7648 7658 +10
+ Misses 1583 1575 -8
+ Partials 492 490 -2
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
Summary: * WIP, still needs tests and docs * tests * flake8 * Docs + fixed some tests * proper error messages Reviewed By: NicolasHug, cpuhrsch Differential Revision: D26945732 fbshipit-source-id: 765c48af203ba27894881dea596f94d2f4a6794d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (part of) #2868
This PR adds a new
max_sizeparameter toResize. If the size of the resized image is greater thanmax_size, than the image is resized again to fit withinmax_size. This is similar to Detectron2's https://github.com/facebookresearch/detectron2/blob/911b091c23a29c624606475d6a2f345568d79e52/detectron2/data/transforms/augmentation_impl.py#L122