Skip to content

enable tests for WIDERFace on Windows #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 19, 2021

Not sure why we included it in the first place. I missed that during review in #2883.

@pmeier pmeier requested review from NicolasHug and fmassa and removed request for NicolasHug March 19, 2021 09:08
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green :), thanks!

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #3589 (3b2d124) into master (85fcea6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3589   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         105      105           
  Lines        9786     9786           
  Branches     1572     1572           
=======================================
  Hits         7738     7738           
  Misses       1567     1567           
  Partials      481      481           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fcea6...3b2d124. Read the comment docs.

@NicolasHug NicolasHug merged commit 8aba1dc into pytorch:master Mar 19, 2021
@pmeier pmeier deleted the enable-widerface-win branch March 19, 2021 10:45
facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2021
Reviewed By: fmassa

Differential Revision: D27433920

fbshipit-source-id: b96ab35b06652aeaddd364cd045891367217cf29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants