Add missing doc for get_video_backend #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Apr 7, 2021
There was a problem hiding this comment.
Thanks @bjuncek , it looks like your editor automatically formatted some unrelated code: it's better to avoid this as it tends to break git blame. In big PRs, it can also complicate the review with noisy changes
Co-authored-by: Nicolas Hug <[email protected]>
This reverts commit f9e847e 7d17834bece36614ca241c6db970.
|
Hi @NicolasHug - yeah makes sense. Sorry for the bother. I've reverted the change and only updated the docstring per your suggestion. Best, |
NicolasHug
approved these changes
Apr 7, 2021
NicolasHug
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
Summary: Reviewed By: NicolasHug Differential Revision: D27706956 fbshipit-source-id: c5e3f4030b9df7081d72ea9a2e307cadb9f0a676 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #3633