Ported STL10 dataset's tests to new test framework #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
requested changes
Apr 14, 2021
There was a problem hiding this comment.
Hey @prabhat00155 thanks for the PR. I have a few comments below. In general, we should make sure that we don't reduce coverage while porting dataset tests.
pmeier
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Few nitpicks left, but otherwise LGTM! Thanks @prabhat00155.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Summary: * Ported STL10 dataset's tests to new test framework * Added additional tests * Removed unused import * Made private methods static and other minor changes Reviewed By: NicolasHug Differential Revision: D28169120 fbshipit-source-id: 76c76eea783984c624f853442455c1c2e6289877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #3531