Make torchscript parameter constraints more obvious #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DOC CI was green so I'll merge, thanks for the review! |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Reviewed By: NicolasHug Differential Revision: D28169139 fbshipit-source-id: 4e3917d8c0bdd75e702d18f2b119bd19208a2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.. note::directive everywhere we document that torchscript expects a sequence of length 1 for a given parameter.This might help avoiding the confusion in #3692