Skip to content

Clean up test accept behaviour #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

Clean up test accept behaviour #3759

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a3742d
Fix accept env var default value
datumbox May 3, 2021
5eb829b
Merge branch 'master' into tests/accept_cleanup
NicolasHug May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/common_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def set_rng_seed(seed):
np.random.seed(seed)


ACCEPT = os.getenv('EXPECTTEST_ACCEPT')
ACCEPT = os.getenv('EXPECTTEST_ACCEPT', '0') == '1'
TEST_WITH_SLOW = os.getenv('PYTORCH_TEST_WITH_SLOW', '0') == '1'


Expand Down Expand Up @@ -121,7 +121,7 @@ def assertExpected(self, output, name, prec=None):
pickable with `torch.save`. This file
is placed in the 'expect' directory in the same directory
as the test script. You can automatically update the recorded test
output using --accept.
output using an EXPECTTEST_ACCEPT=1 env variable.
"""
expected_file = self._get_expected_file(name)

Expand Down