Allow float images in draw_bounding_box #3827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
NicolasHug
commented
May 13, 2021
| dog1_int = read_image(str(Path('assets') / 'dog1.jpg')) | ||
| dog1 = convert_image_dtype(dog1_int, dtype=torch.float) |
There was a problem hiding this comment.
We still need the int images for make_grid but quite frankly I'm tempted to remove make_grid from this example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3820 and on #3824 (their changes are included in this PR), which should be merged first.
This PR lets
draw_bounding_boxnatively support float images in [0, 1] which avoids keeping the uint8 images around