Port NMS tests to use pytest #3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on the |
|
Thanks for the feedback, I renamed it to |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 19, 2021
…rator (#3852) Reviewed By: cpuhrsch Differential Revision: D28538772 fbshipit-source-id: 208d3c67d24f4bc7d804bcc3dd56fb9be346880a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the current tests for nms so that they rely on pytest.
It also introduces the
doesnt_need_cudadecorator which is pretty much the opposite ofneeds_cuda: it allows not to run the CPU-only tests on CI GPU machines, since those CPU tests will be run by the CPU-only machines already. Wouldno_cudabe a better name?cpu_only?