Skip to content

Updated all_gather() to make use of all_gather_object() #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2021

Conversation

prabhat00155
Copy link
Contributor

Resolves #3804.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks a lot @prabhat00155 !

Out of curiosity, did you see any differences with the current implementation compared to the previous one when running inference for detection?

@prabhat00155
Copy link
Contributor Author

Changes LGTM, thanks a lot @prabhat00155 !

Out of curiosity, did you see any differences with the current implementation compared to the previous one when running inference for detection?

IoU metrics stay the same.

@prabhat00155 prabhat00155 merged commit 59c6731 into pytorch:master May 19, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/update_ref branch May 19, 2021 16:00
facebook-github-bot pushed a commit that referenced this pull request May 20, 2021
Reviewed By: prabhat00155

Differential Revision: D28567847

fbshipit-source-id: d58760750bb7e7a06735bbbbf2d054ac7577f7d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace uses of custom all_gather with PyTorch's all_gather_object
4 participants