Updated all_gather() to make use of all_gather_object() #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
May 19, 2021
There was a problem hiding this comment.
Changes LGTM, thanks a lot @prabhat00155 !
Out of curiosity, did you see any differences with the current implementation compared to the previous one when running inference for detection?
IoU metrics stay the same. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2021
Reviewed By: prabhat00155 Differential Revision: D28567847 fbshipit-source-id: d58760750bb7e7a06735bbbbf2d054ac7577f7d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3804.