Skip to content

[FBcode->GH] Added url to class mapping logic to manifold download #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021

Conversation

prabhat00155
Copy link
Contributor

Reviewed By: fmassa

Differential Revision: D28537606

fbshipit-source-id: beaf15f4e38a7d986ef26587383aa2aee3e48952

Reviewed By: fmassa

Differential Revision: D28537606

fbshipit-source-id: beaf15f4e38a7d986ef26587383aa2aee3e48952
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One thing to keep in mind is to add the [FBcode->GH] prefix to the commit message before merging it

@prabhat00155 prabhat00155 merged commit 26e3473 into pytorch:master May 20, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/export_diff branch May 20, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants