Skip to content

[FBcode->GH] Added url to class mapping logic to manifold download #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

[FBcode->GH] Added url to class mapping logic to manifold download #3864

merged 1 commit into from
May 20, 2021

Conversation

prabhat00155
Copy link
Contributor

Reviewed By: fmassa

Differential Revision: D28537606

fbshipit-source-id: beaf15f4e38a7d986ef26587383aa2aee3e48952

@prabhat00155
Added url to class mapping logic to manifold download
504949c 
Reviewed By: fmassa

Differential Revision: D28537606

fbshipit-source-id: beaf15f4e38a7d986ef26587383aa2aee3e48952
@prabhat00155 prabhat00155 requested review from datumbox and fmassa May 20, 2021 11:34
@prabhat00155 prabhat00155 requested a review from NicolasHug May 20, 2021 11:35
NicolasHug
NicolasHug approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fmassa
fmassa approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One thing to keep in mind is to add the [FBcode->GH] prefix to the commit message before merging it

@prabhat00155 prabhat00155 merged commit 26e3473 into pytorch:master May 20, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/export_diff branch May 20, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@fmassa fmassa fmassa approved these changes

@datumbox datumbox Awaiting requested review from datumbox

Assignees
No one assigned
Labels
cla signed module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prabhat00155 @NicolasHug @fmassa @datumbox @facebook-github-bot