-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Fix bug on detection backbones when trainable_layers == 0 #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vfdev-5 We seem to have a flaky test related to bicubic interpolation:
|
@datumbox I refactored the test using pytest and could find seed value with MAE larger 8 as here. The case when it is failing looks like to be related to max_size=33. I suppose that odd values are not handled in the same way between PIL and pytorch. If we use max_size=34 I could not find a seed value between 0 to 2000 such that MAE > 8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…3906) Summary: * Fix a bug when trainable_layers == 0 * Fix same issue on ssd. Reviewed By: vincentqb, cpuhrsch Differential Revision: D28679976 fbshipit-source-id: 79061750c7bb6b3d9f069056df15f6d682c3ca56
Fixes #3905