Skip to content

Revert "addressing #3805: remove deprecated function call 3" #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

prabhat00155
Copy link
Contributor

Reverts #3861

@fmassa
Copy link
Member

fmassa commented Jun 7, 2021

@bjuncek we got internal failures with this PR.

Prabhat will be sending a follow-up PR that addresses the issues

@prabhat00155 prabhat00155 merged commit 7fb4ef5 into master Jun 7, 2021
@fmassa fmassa deleted the revert-3861-bkorbar/depretiation_3 branch June 7, 2021 11:26
@fmassa
Copy link
Member

fmassa commented Jun 7, 2021

@prabhat00155 Just a remainder that you forgot to add the [FBcode->GH] tag, as we won't be merging the other PR in fbcode so we will need to skip this one

@prabhat00155
Copy link
Contributor Author

@prabhat00155 Just a remainder that you forgot to add the [FBcode->GH] tag, as we won't be merging the other PR in fbcode so we will need to skip this one

@fmassa Isn't [FBcode->GH] to be added when we import from FBcode?

@NicolasHug
Copy link
Member

Isn't [FBcode->GH] to be added when we import from FBcode?

It needs to be added when we want to ignore a PR during the GH -> fbcode syncing. PRs imported from fbcode are a subset of that only. But you do make a point that the tag isn't as general as it could ;)

@prabhat00155
Copy link
Contributor Author

Isn't [FBcode->GH] to be added when we import from FBcode?

It needs to be added when we want to ignore a PR during the GH -> fbcode syncing. PRs imported from fbcode are a subset of that only. But you do make a point that the tag isn't as general as it could ;)

@NicolasHug Thanks for explaining that. Perhaps we should have a tag called FBCode Ignore or something like that.

@datumbox
Copy link
Contributor

datumbox commented Jun 7, 2021

@prabhat00155 There is another param you can use on the script to ignore a specific commit id. Just note it operates on full git hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants