Skip to content

ping maintainers in case a PR was not properly labeled #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2021
Merged

ping maintainers in case a PR was not properly labeled #3993

merged 8 commits into from
Jun 9, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jun 7, 2021 •
edited
Loading

Addresses #3351 (comment).

@pmeier pmeier marked this pull request as ready for review June 8, 2021 13:28
@pmeier pmeier changed the title test label extraction ping maintainers in case a PR was not properly labeled Jun 8, 2021
pmeier
pmeier commented Jun 8, 2021
View reviewed changes
pmeier
pmeier commented Jun 8, 2021
View reviewed changes
Copy link
Collaborator Author

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow will probably not work the first few times due to small bugs. Since I cannot test the workflow locally, we need to merge and fix the teething issues as we go. I don't expect false positives, i.e. noise on the PRs.

@pmeier pmeier requested a review from NicolasHug June 8, 2021 13:33
datumbox
datumbox approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping so that you can merge when ready and test it out.

@pmeier pmeier merged commit aaf240f into pytorch:master Jun 9, 2021
@pmeier pmeier deleted the require-labeled-prs branch June 9, 2021 05:10
@pmeier pmeier mentioned this pull request Jun 9, 2021
Merged
fmassa
fmassa reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this @pmeier!

facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
@NicolasHug @facebook-github-bot
[fbsync] ping maintainers in case a PR was not properly labeled (#3993)
ef4887c 
Summary:
* test label extraction

* debug

* debug

* ping maintainers in case a PR was not properly labeled

* flake8

* add required labels

Reviewed By: fmassa

Differential Revision: D29097744

fbshipit-source-id: d4247a9a33988a8b1f25f1bbb14bec4d3ad9ff6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa left review comments

@datumbox datumbox datumbox approved these changes

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmeier @NicolasHug @datumbox @fmassa @facebook-github-bot