supoort single color in utils.draw_bounding_boxes #4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jun 18, 2021
There was a problem hiding this comment.
Thanks @Separius , this looks good. Could you please add a test in test/test_utils.py making sure that single colors are effectively supported? No need to go overboard, we can just check that strings and tuples are accepted, without necessarily checking the output.
NicolasHug
reviewed
Jun 21, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
Reviewed By: NicolasHug Differential Revision: D29369892 fbshipit-source-id: 395b11c7baf641f4f9afa5b1aa17f8de2a8dfcad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.