Added missing arg description in lraspp_mobilenet_v3_large #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jul 30, 2021
| @@ -181,6 +181,7 @@ def lraspp_mobilenet_v3_large(pretrained=False, progress=True, num_classes=21, * | |||
| contains the same classes as Pascal VOC | |||
| progress (bool): If True, displays a progress bar of the download to stderr | |||
| num_classes (int): number of output classes of the model (including the background) | |||
| aux_loss (bool): If True, it uses an auxiliary loss | |||
There was a problem hiding this comment.
thanks for the PR @frgfm
If you look just below we have
if kwargs.pop("aux_loss", False):
raise NotImplementedError('This model does not use auxiliary loss')So documenting aux_loss is actually more confusing than anything. We should instead indicate how the kwargs argument is used
There was a problem hiding this comment.
Oh my bad, I misread, I thought the arg was declared outside of kwargs!
There was a problem hiding this comment.
We'll be happy to consider a Pr for kwargs though, if you feel like it :) !
There was a problem hiding this comment.
Mmmh, what do you have in mind?
Something like saying whose kwargs are those and mentioning the special case of aux_loss?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing argument description for
lraspp_mobilenet_v3_large.Any feedback is welcome!