Skip to content

Add typing Annotations to detection/utils #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 12, 2021
Merged

Add typing Annotations to detection/utils #4583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
50ab495
Start annotating utils
oke-aditya Oct 10, 2021
dab9402
checking
khushi-411 Oct 11, 2021
5f7d0d9
Add annotations at _utils.py
khushi-411 Oct 11, 2021
d017161
Remove unnecessary comments.
khushi-411 Oct 11, 2021
8e83805
Merge branch 'main' into type_utils
khushi-411 Oct 11, 2021
f6bb442
re-checked typings
khushi-411 Oct 11, 2021
c4c2884
Update typing
oke-aditya Oct 11, 2021
f157190
Ignore small error
oke-aditya Oct 11, 2021
f1df465
Use optional tensor
oke-aditya Oct 11, 2021
c8fa413
Merge branch 'main' into type_utils
oke-aditya Oct 11, 2021
f78dd49
Ignore for JIT
oke-aditya Oct 11, 2021
4df6ccf
Merge branch 'main' into type_utils
datumbox Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@ ignore_errors = True

ignore_errors = True


[mypy-torchvision.models.detection.image_list]

ignore_errors = True


[mypy-torchvision.models.detection.transform]

ignore_errors = True
Expand Down
6 changes: 3 additions & 3 deletions torchvision/models/detection/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def __init__(self, batch_size_per_image: int, positive_fraction: float) -> None:
"""
Args:
batch_size_per_image (int): number of elements to be selected per image
positive_fraction (float): percentace of positive elements per batch
positive_fraction (float): percentage of positive elements per batch
"""
self.batch_size_per_image = batch_size_per_image
self.positive_fraction = positive_fraction
Expand Down Expand Up @@ -261,7 +261,7 @@ def __init__(self, high_threshold: float, low_threshold: float, allow_low_qualit
self.low_threshold = low_threshold
self.allow_low_quality_matches = allow_low_quality_matches

def __call__(self, match_quality_matrix) -> Tensor:
def __call__(self, match_quality_matrix: Tensor) -> Tensor:
"""
Args:
match_quality_matrix (Tensor[float]): an MxN tensor, containing the
Expand Down Expand Up @@ -330,7 +330,7 @@ def set_low_quality_matches_(self, matches: Tensor, all_matches: Tensor, match_q


class SSDMatcher(Matcher):
def __init__(self, threshold):
def __init__(self, threshold: float) -> None:
super().__init__(threshold, threshold, allow_low_quality_matches=False)

def __call__(self, match_quality_matrix: Tensor) -> Tensor:
Expand Down