Skip to content

Simplify efficientnet code by removing _efficientnet_conf #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2021

Conversation

jdsgomes
Copy link
Contributor

@jdsgomes jdsgomes requested a review from datumbox October 21, 2021 14:43
@jdsgomes jdsgomes changed the title Simplify efficientnet code by removing _efficientnet_conf [DRAT] Simplify efficientnet code by removing _efficientnet_conf Oct 21, 2021
@datumbox datumbox marked this pull request as draft October 21, 2021 15:39
@datumbox datumbox changed the title [DRAT] Simplify efficientnet code by removing _efficientnet_conf [WIP] Simplify efficientnet code by removing _efficientnet_conf Oct 21, 2021
@jdsgomes jdsgomes marked this pull request as ready for review October 22, 2021 10:07
@jdsgomes jdsgomes changed the title [WIP] Simplify efficientnet code by removing _efficientnet_conf Simplify efficientnet code by removing _efficientnet_conf Oct 22, 2021
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jdsgomes jdsgomes merged commit f8468e7 into pytorch:main Oct 22, 2021
@jdsgomes jdsgomes linked an issue Oct 22, 2021 that may be closed by this pull request
13 tasks
facebook-github-bot pushed a commit that referenced this pull request Oct 26, 2021
…4690)

Summary:
* adding efficientnet to prototype

* Removing _efficientnet_conf from prototype and main efficientnet classification models

* fixing merge conflicts

* fixing merge conflicts

* fixing lint errors

* fixing lint errors

* fixing lint errors

Reviewed By: NicolasHug

Differential Revision: D31916338

fbshipit-source-id: 6b6b52809e0b701fd5fb66e014c4ff5d7453afe9
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
* adding efficientnet to prototype

* Removing _efficientnet_conf from prototype and main efficientnet classification models

* fixing merge conflicts

* fixing merge conflicts

* fixing lint errors

* fixing lint errors

* fixing lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-pretrained weights: Add model builders for Classification
3 participants