Skip to content

[FBcode->GH] Removed type annotations from rcnn #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Nov 8, 2021

These type annotations were causing test failures in Phabricator. Hence, these were removed in D32216673.

cc @datumbox

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 8, 2021

💊 CI failures summary and remediations

As of commit 34e24bf (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

2 failures not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.9_cu111 packaging/build_conda.sh 🔁 rerun
CircleCI binary_libtorchvision_ops_android Build 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.9_cu111

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping

Do you remember what the issue was? Where the new annotations incorrect or is it something else?

@prabhat00155
Copy link
Contributor Author

Stamping

Do you remember what the issue was? Where the new annotations incorrect or is it something else?

Error details: https://github.com/pytorch/vision/pull/4631/files#r744161323

@prabhat00155
Copy link
Contributor Author

@NicolasHug Detailed error can be viewed here: https://www.internalfb.com/diff/D32216673?dst_version_fbid=621645568869442, under diff signals.

@oke-aditya
Copy link
Contributor

Just a small doubt @prabhat00155 can we use the Python annotations which are commented ? Or is that too causing failure?

@prabhat00155
Copy link
Contributor Author

Just a small doubt @prabhat00155 can we use the Python annotations which are commented ? Or is that too causing failure?

The type annotations in arguments in eager_outputs() and forward() was causing some pyre errors in a third-party file.

Unused ignore [0]: The `pyre-ignore` or `pyre-fixme` comment is not suppressing type errors, please remove it. 

Also, the return type was causing a test failure as discussed before.

@prabhat00155 prabhat00155 merged commit bbd9ff8 into pytorch:main Nov 8, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/type_annotations branch November 8, 2021 19:32
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox
Copy link
Contributor

datumbox commented Nov 8, 2021

@prabhat00155 I don't think this change is considered bc breaking. I would also probably mark is as bug fix because the previous typing broke some use-cases and this PR addresses it.

cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@mpearce25 mpearce25 mentioned this pull request Feb 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants