-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[FBcode->GH] Removed type annotations from rcnn #4883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FBcode->GH] Removed type annotations from rcnn #4883
Conversation
💊 CI failures summary and remediationsAs of commit 34e24bf (more details on the Dr. CI page):
2 failures not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamping
Do you remember what the issue was? Where the new annotations incorrect or is it something else?
Error details: https://github.com/pytorch/vision/pull/4631/files#r744161323 |
@NicolasHug Detailed error can be viewed here: https://www.internalfb.com/diff/D32216673?dst_version_fbid=621645568869442, under |
Just a small doubt @prabhat00155 can we use the Python annotations which are commented ? Or is that too causing failure? |
The type annotations in arguments in
Also, the return type was causing a test failure as discussed before. |
Hey @prabhat00155! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
@prabhat00155 I don't think this change is considered bc breaking. I would also probably mark is as bug fix because the previous typing broke some use-cases and this PR addresses it. |
These type annotations were causing test failures in Phabricator. Hence, these were removed in D32216673.
cc @datumbox