Adding logging calls for raft and vit #5044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 7930c46 (more details on the Dr. CI page):
2 failures not recognized by patterns:
2 jobs timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
approved these changes
Dec 7, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
Summary: * Adding logging calls for raft and vit * Linter fix Reviewed By: NicolasHug Differential Revision: D32950945 fbshipit-source-id: 881a032c4e6e0d7444120aa0fa658d051516cde7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we missed adding the logger on the constructor of the newest models. Not sure if we can automate the check but until then might be worth building a memory muscle to check in the PR reviews prior merging.
cc @datumbox @sallysyw @kazhang @prabhat00155 @NicolasHug @pmeier @fmassa