Skip to content

Add API usage calls to utils #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Add API usage calls to utils #5077

merged 3 commits into from
Dec 10, 2021

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented Dec 9, 2021

Add the public methods calls API in utils.

Close #5074

cc @datumbox @kazhang

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 9, 2021

💊 CI failures summary and remediations

As of commit 1a3b7a2 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox requested a review from kazhang December 9, 2021 11:29
@datumbox
Copy link
Contributor

datumbox commented Dec 9, 2021

@zhiqwang LGTM, thanks for the help!

I'll leave it to @kazhang to approve. I know he has another PR which changes the arguments of the logging method at #5072. Not sure at which order he wants to merge.

@kazhang
Copy link
Contributor

kazhang commented Dec 9, 2021

@zhiqwang Thanks for your contribution! I just merged #5072, could you please update the PR to use the new API?

Copy link
Contributor

@kazhang kazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhiqwang for your contributions!

@kazhang kazhang merged commit c34a914 into pytorch:main Dec 10, 2021
@github-actions
Copy link

Hey @kazhang!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@zhiqwang zhiqwang deleted the utils-log-api branch December 10, 2021 07:13
facebook-github-bot pushed a commit that referenced this pull request Dec 21, 2021
Summary:
* Add API usage calls to utils

* Update to the new api

Reviewed By: prabhat00155

Differential Revision: D33253471

fbshipit-source-id: 58794daa95d8cefe4bcff545c6a462a2287602b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API usage calls to utils
4 participants