only set random generator if shuffle=true #5135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4aaa362 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
approved these changes
Jan 2, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]> Reviewed By: datumbox, prabhat00155 Differential Revision: D33405361 fbshipit-source-id: 83c93424be8c68327e6bdaee5ef726f3d0c0ab33
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
…5135) Differential Revision: D33405361 Original commit changeset: 83c93424be8c Original Phabricator Diff: D33405361 fbshipit-source-id: c7a9d50e4a83030b0744e0ea8b5a8066c94f4880
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]> Reviewed By: sallysyw Differential Revision: D33479280 fbshipit-source-id: 98bea39e632f1bb715a9b69e595a83f7266a14b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is about #5051
set random_generator only when shuffle=true, just like https://pytorch.org/docs/stable/_modules/torch/utils/data/distributed.html#DistributedSampler
cc @datumbox