-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Adding min_size to classification and video models #5223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit a38ef88 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f-parfenov The changes look good. I only left 2 minor comments, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @f-parfenov! The failing test on prototype is unrelated. I'll merge once all other tests pass.
Summary: * Adding min_size as a required field. * Adding min_size to classification models (quantized and not) * Adding min_size to video models meta. * Moving min_size to _COMMON_META * Fixing extra line Reviewed By: jdsgomes, prabhat00155 Differential Revision: D33739383 fbshipit-source-id: 4984d7aebd0e46d8ef9c769b553e8f0faea91654 Co-authored-by: Vasilis Vryniotis <[email protected]>
Fixes #5199, I have added the min_size to classification and video model.
The unit test has been updated and passes for all targeted models.
To obtain the min_size values (including the newer models and the video models) I have adapted the following script from #3944 :
Which gave me the following values:
@datumbox
cc @datumbox @bjuncek