-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix docstring by removing ResNet #5238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mohrez86! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
💊 CI failures summary and remediationsAs of commit 02899f9 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
Run tests | 🔁 rerun |
🚧 1 ongoing upstream failure:
These were probably caused by upstream breakages that are not fixed yet.
- unittest_prototype since Jan 14 (adf8466)
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@NicolasHug @jdsgomes Tagging you to see the feedback of @mohrez86 who is a first-time contributor. He faced a few problems which are worth addressing on the future. I believe the issues he describes with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohrez86 The changes LGTM, thanks a lot! Sorry for the hiccups with our documentation. We will focus on improving this in H1. Hope you will stick around and contribute more on the project.
Reviewed By: jdsgomes, prabhat00155 Differential Revision: D33739374 fbshipit-source-id: d077c9d85b6a945b7327c331d488cdd9080ed3fd
The PR fixes the documentation bug discussed in issue #5209.
I tried to follow the instructions in the file CONTRIBUTING.md.
The tool
ufmt
makes several changes in several modules. So, I did not include the changes in this PR. I can add them if it is necessary.Building the documentation using the command
make html
results in a runtime error (maybe it is a problem on my side).However, running
make html-noplot
finishes with no error.