Default colorspace for CPU decoder is now ITU709

[bjuncek]

Addressing #5245

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 0f8a072 (more details on the Dr. CI page):

---

• 1/5 failures introduced in this PR
• 4/5 broken upstream at merge base 61a52b9 from Feb 01 until Feb 02

---

1 failure not recognized by patterns:

Job	Step	Action
cmake_macos_cpu	curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
	🔁 rerun

---

🚧 4 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

• unittest_linux_cpu_py3.8 from Feb 01 until Feb 02 (9d7177f - 8a16e12)
  • 🔁 rerun
• unittest_linux_cpu_py3.7 from Feb 01 until Feb 02 (9d7177f - 8a16e12)
  • 🔁 rerun
• unittest_prototype on Feb 02 from 2:09am to 3:11am (61a52b9 - 8a16e12)
  • 🔁 rerun
• unittest_linux_cpu_py3.9 from Feb 01 until Feb 02 (9d7177f - 8a16e12)
  • 🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[prabhat00155]

Thanks @bjuncek, this looks good to me. I have a few minor comments for you to consider.

[prabhat00155]

@bjuncek Also, could you fix the linter error please?

[prabhat00155]

Internal tests: D33830672

[prabhat00155]

Some internal tests are failing, blocking merge for now.

[bjuncek]

I think I've addressed most of the concerns, and have added additional coverage for video_reader tests

[bjuncek]

@prabhat00155 @datumbox any updates on this?

[datumbox]

@bjuncek I don't have any context about this PR. Not sure if @prabhat00155 or @fmassa can help here.

BTW there is a conflict in one of the test files, I assume you will take care of it after you get the OK on principle for the direction of the PR?

[prabhat00155]

@datumbox This PR would need to be imported into Phabricator to make sure all the internals tests are fine, before merging here, as we are changing the colour space for CPU decoder, which means the output values would be different. Last time, I saw some internal test failures on importing this(D33830672).