Skip to content

Added python 3.10 to CI #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added python 3.10 to CI #5320

wants to merge 3 commits into from

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jan 31, 2022

Description:

  • Added python 3.10 to CI by updating .circleci/regenerate.py and running it to update .circleci/config.yml
    • skipped macosx as no 3.10 binaries yet.

@facebook-github-bot
Copy link

facebook-github-bot commented Jan 31, 2022

💊 CI failures summary and remediations

As of commit 08a530d (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier
Copy link
Collaborator

pmeier commented Jan 31, 2022

Could you also check #5161 and add 3.10 where ever we removed 3.6? Plus, we also need to adapt the compatibility table in the README.

@@ -42,6 +42,9 @@ def build_workflows(prefix="", filter_branch=None, upload=False, indentation=6,
# ROCm conda packages not yet supported
if cu_version.startswith("rocm") and btype == "conda":
continue
# Skip MacOSX and python 3.10
if python_version == "3.10" and os_type == "macos":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing dependencies? Can you link to the issue/error so that the release engineering team have visibility?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll search for the issue. I think they may be still working on binaries for macosx as pytorch/pytorch#66424 is not yet closed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the check and unblock the PR once they have fixed the macosx binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants