properly deprecate legacy implementation -- bis #5391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a9b8bf2 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
added
code quality
deprecation
other
pmeier
approved these changes
Feb 8, 2022
oke-aditya
reviewed
Feb 8, 2022
prabhat00155
approved these changes
Feb 9, 2022
torchvision/datasets/voc.py
Outdated
| @@ -80,7 +80,8 @@ def __init__( | |||
| if year == "2007-test": | |||
| if image_set == "test": | |||
| warnings.warn( | |||
| "Acessing the test image set of the year 2007 with year='2007-test' is deprecated. " | |||
| "Acessing the test image set of the year 2007 with year='2007-test' is deprecated " | |||
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Feb 9, 2022
* More deprecations * update message * typo
This was referenced Feb 9, 2022
jdsgomes
pushed a commit
that referenced
this pull request
Feb 9, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
Summary: * More deprecations * update message * typo Reviewed By: NicolasHug Differential Revision: D34140245 fbshipit-source-id: 00c50eb58e9d5f70614bc971c2ede41a66ccbbf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more deprecations that I forgot in #5387