Fix functional.adjust_gamma #5427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 9f0cb0a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@malfet Are you sure this is the case? import PIL.Image
gamma = 1.0
gain = 1.0
img = PIL.Image.open("test/assets/encode_jpeg/grace_hopper_517x606.jpg")
img = img.convert("RGB")
gamma_map = [(255 + 1 - 1e-3) * gain * pow(ele / 255.0, gamma) for ele in range(256)] * 3
img = img.point(gamma_map)works out fine for me. I don't see anything that should change just from using Python 3.10. Could you point me to a CI run where the error is happening? |
|
@datumbox thank you! All my years at Oculus finally starting to pay off :) |
jdsgomes
pushed a commit
to jdsgomes/vision
that referenced
this pull request
Feb 16, 2022
This was referenced Feb 16, 2022
datumbox
pushed a commit
that referenced
this pull request
Feb 16, 2022
Co-authored-by: Nikita Shulga <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 25, 2022
Reviewed By: jdsgomes Differential Revision: D34475324 fbshipit-source-id: cbee37b84d6454aca4a98c559f20fb2c2a565175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while trying to enable CI on python-3.10
Apparently array passed to
Image.pointshould be array of integers for "RGB" image mode