Skip to content

Recoded gaussian blur using pil_to_tensor instead of to_tensor#5503

Merged
vfdev-5 merged 2 commits into
pytorch:mainfrom
vfdev-5:depr-to-tensor
Mar 1, 2022
Merged

Recoded gaussian blur using pil_to_tensor instead of to_tensor#5503
vfdev-5 merged 2 commits into
pytorch:mainfrom
vfdev-5:depr-to-tensor

Conversation

@vfdev-5

@vfdev-5 vfdev-5 commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Description:

  • Recoded gaussian blur using pil_to_tensor instead of to_tensor
  • Additionally, fixed docs for resize/antialias option

@facebook-github-bot

facebook-github-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

💊 CI failures summary and remediations

As of commit 541a5e8 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 thanks for the PR. Just a couple of comments, let me know what you think!

Comment thread torchvision/transforms/functional.py Outdated
Comment thread torchvision/transforms/transforms.py Outdated
Comment thread torchvision/prototype/transforms/functional/_misc.py
@vfdev-5

vfdev-5 commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

@datumbox thanks for the review ! Sounds good to me to remove the warnings and just scope for gaussian blur update.

@vfdev-5 vfdev-5 changed the title Added warning about deprecated to_tensor/ToTensor Recoded gaussian blur using pil_to_tensor instead of to_tensor Mar 1, 2022

@datumbox datumbox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5 vfdev-5 merged commit b8de0b8 into pytorch:main Mar 1, 2022
@vfdev-5 vfdev-5 deleted the depr-to-tensor branch March 1, 2022 15:40
@github-actions

github-actions Bot commented Mar 1, 2022

Copy link
Copy Markdown

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2022
Reviewed By: datumbox

Differential Revision: D34579505

fbshipit-source-id: cddd5dc73bcb7e12338c785381e1f51e8f1c702f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants