Skip to content

Recoded gaussian blur using pil_to_tensor instead of to_tensor #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2022
Merged

Recoded gaussian blur using pil_to_tensor instead of to_tensor #5503

merged 2 commits into from
Mar 1, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 1, 2022 •
edited
Loading

Description:

  • Recoded gaussian blur using pil_to_tensor instead of to_tensor
  • Additionally, fixed docs for resize/antialias option

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 1, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 541a5e8 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 thanks for the PR. Just a couple of comments, let me know what you think!

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Mar 1, 2022

@datumbox thanks for the review ! Sounds good to me to remove the warnings and just scope for gaussian blur update.

@vfdev-5 vfdev-5 changed the title Added warning about deprecated to_tensor/ToTensor Recoded gaussian blur using pil_to_tensor instead of to_tensor Mar 1, 2022
@pmeier pmeier mentioned this pull request Mar 1, 2022
Closed
datumbox
datumbox approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5 vfdev-5 merged commit b8de0b8 into pytorch:main Mar 1, 2022
@vfdev-5 vfdev-5 deleted the depr-to-tensor branch March 1, 2022 15:40
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2022
@prabhat00155 @facebook-github-bot
[fbsync] Recoded gaussian blur without using to_tensor (#5503)
7998be9 
Reviewed By: datumbox

Differential Revision: D34579505

fbshipit-source-id: cddd5dc73bcb7e12338c785381e1f51e8f1c702f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @facebook-github-bot @datumbox