support grayscale / RGB alpha conversions #5567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 803bc9a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Mar 8, 2022
vfdev-5
reviewed
Mar 9, 2022
test/test_prototype_transforms.py
Outdated
Comment on lines
163
to
188
| @parametrize( | ||
| [ | ||
| ( | ||
| transforms.ConvertImageColorSpace(color_space=new_color_space, old_color_space=old_color_space), | ||
| itertools.chain.from_iterable( | ||
| [ | ||
| fn(color_spaces=[old_color_space]) | ||
| for fn in ( | ||
| make_images, | ||
| make_vanilla_tensor_images, | ||
| make_pil_images, | ||
| ) | ||
| ] | ||
| ), | ||
| ) | ||
| for old_color_space, new_color_space in itertools.product( | ||
| [ | ||
| features.ColorSpace.GRAYSCALE, | ||
| features.ColorSpace.GRAYSCALE_ALPHA, | ||
| features.ColorSpace.RGB, | ||
| features.ColorSpace.RGBA, | ||
| ], | ||
| repeat=2, | ||
| ) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Nit: It is not only related to this one but for previous as well. IMO these parametrizations are really hard to read and understand... If we could simplify that somehow, it would be nice. Major difficulty is get what is passed to input for example...
There was a problem hiding this comment.
It is indeed hard to read. Refactoring the tests is at the top of my todo list.
datumbox
reviewed
Mar 9, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: * support grayscale / RGB alpha conversions * use _max_valu from stable * remove extra copy for PIL conversion * simplify test image generation for color spaces with alpha channel * use common _max_value in tests * replace dynamically created dicts with if/else * make color space conversion more explicit * make even more explicit * simplify alpha image generation * fix if / elif * add error for unknown conversions * rename RGBA to RGB_ALPHA * cleanup * GRAYSCALE to GRAY Reviewed By: vmoens Differential Revision: D34878979 fbshipit-source-id: 4ec3af94e73152d11017c4e9c57ded44b2076764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5510.