Skip to content

upgrade to next-gen CircleCI convenience images #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 31, 2022

All workflows that currently run on a circleci/* docker image issue this warning:

circleci_warning

Example workflow.

The warning points to this thread. TL;DR: we should to migrate to cimg/* images as the circleci/* images will no longer receive support starting from 2023. Otherwise nothing should change 🤞

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 31, 2022

💊 CI failures summary and remediations

As of commit ea21385 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 31, 2022

It seems the tagging scheme for Android images has changed from the API version, e.g. circleci/android:api-29-ndk to a time-based one, e.g. cimg/android:2022.03-ndk. I couldn't find an official "conversion table" or something similar. I'll ask for clarification.

We are currently using API version 29, which was published in September 2019 and got its latest update in July 2020. The earliest next-gen image is from August 2021. If I'm not mistaken, the next-gen image installs the SDK for all API versions from 23 to 31 whereas the legacy only installs for API version 29. Maybe we need to specify the SDK version we want to build against instead of relying on the only one installed?

Someone with Android experience should have a look to see if this will affect our workflows. In the meantime, I'll try the next-gen convenience images to see if CI is happy or not.

Edit:

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 88aaf51 into pytorch:main Mar 31, 2022
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the circleci-nextgen branch March 31, 2022 11:18
@pmeier
Copy link
Collaborator Author

pmeier commented Apr 1, 2022

The support clarified:

The tagging scheme has changed from API level based to date based. This now means that multiple API versions are available at the same time. Any one Android image tag will have at least the 5 most recent API levels.

IIUC, we should really specify the API version we are compiling against. As explained in #5712 (comment), the new image also has API version 30 and 31 installed. If we don't specify, probably the latest version is used, which means that we are now building against 31 instead of 29. The 2022.3 image includes two later versions and it seems to fail without the pin.

facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
Summary:
* upgrade to next-gen CircleCI convenience images

* [DEBUG] try latest Android NDK convenience image

* [DEBUG] try earliest next-gen android image

Reviewed By: NicolasHug

Differential Revision: D35393164

fbshipit-source-id: dd64ddd22fb395a62a4a3bba59b1eb83fb200412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants