-
Notifications
You must be signed in to change notification settings - Fork 7.1k
upgrade to next-gen CircleCI convenience images #5712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit ea21385 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
It seems the tagging scheme for Android images has changed from the API version, e.g. We are currently using API version 29, which was published in September 2019 and got its latest update in July 2020. The earliest next-gen image is from August 2021. If I'm not mistaken, the next-gen image installs the SDK for all API versions from 23 to 31 whereas the legacy only installs for API version 29. Maybe we need to specify the SDK version we want to build against instead of relying on the only one installed? Someone with Android experience should have a look to see if this will affect our workflows. In the meantime, I'll try the next-gen convenience images to see if CI is happy or not. Edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
The support clarified:
IIUC, we should really specify the API version we are compiling against. As explained in #5712 (comment), the new image also has API version 30 and 31 installed. If we don't specify, probably the latest version is used, which means that we are now building against 31 instead of 29. The |
Summary: * upgrade to next-gen CircleCI convenience images * [DEBUG] try latest Android NDK convenience image * [DEBUG] try earliest next-gen android image Reviewed By: NicolasHug Differential Revision: D35393164 fbshipit-source-id: dd64ddd22fb395a62a4a3bba59b1eb83fb200412
All workflows that currently run on a
circleci/*
docker image issue this warning:Example workflow.
The warning points to this thread. TL;DR: we should to migrate to
cimg/*
images as thecircleci/*
images will no longer receive support starting from 2023. Otherwise nothing should change 🤞