Skip to content

Remove publication_year and interpolation meta #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2022
Merged

Remove publication_year and interpolation meta #5848

merged 4 commits into from
Apr 21, 2022

Conversation

YosuaMichael
Copy link
Contributor

resolving #5768

@YosuaMichael YosuaMichael requested a review from datumbox April 21, 2022 09:50
@YosuaMichael YosuaMichael self-assigned this Apr 21, 2022
@datumbox datumbox mentioned this pull request Apr 21, 2022
Closed
datumbox
datumbox approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @YosuaMichael!

torchvision/models/vision_transformer.py
@@ -318,20 +318,16 @@ def _vision_transformer(
return model


_COMMON_META = {
_COMMON_META: Dict[str, Any] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume mypy is to blame for this, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct

@datumbox
Copy link
Contributor

The failures seem unrelated. I've raised the issues separately at #5850 and #5830

@YosuaMichael
Copy link
Contributor Author

The failures seem unrelated. I've raised the issues separately at #5850 and #5830

I will wait until all the tests finished first, just to be safe. After that I will merge if no other test that break.

@datumbox datumbox merged commit 385a44f into pytorch:main Apr 21, 2022
This was referenced Apr 21, 2022
Merged
Merged
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
@YosuaMichael @datumbox @facebook-github-bot
[fbsync] Remove publication_year and interpolation meta (#5848)
e4737e2 
Summary:
* Remove publication_year and interpolation meta

* Add type to _COMMON_META and _COMMON_SWAG_META to prevent error from mypy check

* Remove test to check interpolation and publication_year meta

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095723

fbshipit-source-id: 15e7c00093bcf18393e3e5744d72734cf6fa7aac

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees

@YosuaMichael YosuaMichael

Labels
cla signed code quality module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YosuaMichael @datumbox @facebook-github-bot