use generalised_box_iou function to calculate giou_loss #5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
@abhi-glitchhg thanks for the contribution! :)
Marking as "Request Changes" to avoid accidental merges. Let's chat about this on the other thread linked below to decide a way forwards.
| boxes2 = boxes2[None, :] | ||
| miouk = generalized_box_iou(boxes1, boxes2)[0][0] | ||
| else: | ||
| miouk = generalized_box_iou(boxes1, boxes2).diagonal() |
There was a problem hiding this comment.
This is going to be quite slow as noted at #5786 (comment)
Let's continue our discussion on the other thread just to avoid splitting the comments on various places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the
generalized_box_ioufunction to calculate thegeneralized_box_iou_loss, here is my attempt for the same.cc: @datumbox @pmeier